Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

problems with strong typing and numpy #117

Merged
merged 1 commit into from Feb 15, 2021
Merged

Conversation

N720720
Copy link
Owner

@N720720 N720720 commented Feb 15, 2021

Description

Strong typing was not working with numpy. I try to fix it with typing-extensions, numpy.typing and the numpy.typing.mypy_plugin with no success. I try to make it work with data-science-types but it didn't work either.

Related Issue

Type of Change

  • 馃摎 Examples / docs / tutorials / dependencies update
  • 馃敡 Bug fix (non-breaking change which fixes an issue)
  • 馃 Improvement (non-breaking change which improves an existing feature)
  • 馃殌 New feature (non-breaking change which adds functionality)
  • 馃挜 Breaking change (fix or feature that would cause existing functionality to change)
  • 馃攼 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@N720720 N720720 merged commit ec50be3 into master Feb 15, 2021
@N720720 N720720 deleted the strong_type_numpy_fix branch February 15, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant