remove some useless configuration in settings.py

[childers]

@deming7h777 commented on Thu Oct 11 2018

There are some file have been removed but the configuration is still in settings.py.(ex. jquery-ui.js,...)
It may confuse someone who want to figure out the whole genomics-workspace.

---

@hsiaoyi0504 commented on Fri Oct 12 2018

@deming7h777 Can you elaborate a little bit ? It seems to me that jquery-ui.js is still useful.

---

@deming7h777 commented on Fri Oct 12 2018

I can't find the jquery-ui.js in blast/script directory and even all of the repo, can you give me some suggestion

---

@hsiaoyi0504 commented on Fri Oct 12 2018

It's because it's installed by webpack:

genomics-workspace/webpack.config.js

Line 57 in 84ec7d6

{ from: path.join(nodeModules, '/jquery-ui-dist/jquery-ui.js'), to: blastScripts},

.

---

@deming7h777 commented on Sat Oct 13 2018

I have seen that, i mean i don't find any script or html import jquery-ui.js

---

@hsiaoyi0504 commented on Sat Oct 13 2018

It's imported by django-pipeline through

genomics-workspace/blast/templates/blast/results.html

Line 98 in 84ec7d6

{% javascript 'blast-results' %}

, and in blast_results.js, the jquery-ui widget is called by some syntax like this:

genomics-workspace/blast/static/blast/scripts/blast-results.js

Line 548 in 84ec7d6

$slider.slider({

.

---

@hsiaoyi0504 commented on Sat Oct 13 2018

BTW, this perhaps is a good alternative of django-pipeline: https://django-compressor.readthedocs.io/en/latest/. One important feature attracts me is that

JS/CSS belong in the templates
Every static combiner for Django I’ve seen makes you configure your static files in your settings.py. While that works, it doesn’t make sense. Static files are for display. And it’s not even an option if your settings are in completely different repositories and use different deploy processes from the templates that depend on them. - django-compressor

---

@deming7h777 commented on Mon Oct 15 2018

thanks for reminding !

[hsiaoyi0504]

This should be closed.