Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add External Tile Sets #135

Merged
merged 19 commits into from
Dec 10, 2020
Merged

Add External Tile Sets #135

merged 19 commits into from
Dec 10, 2020

Conversation

gkjohnson
Copy link
Contributor

@gkjohnson gkjohnson commented Dec 10, 2020 •
edited
Loading

Fix #62

TODO

  • Add clarifying comments / variable names
  • Test further
  • Add a test tileset with a tileset that fails to load
  • Add written tests
  • Ensure the loaded tileset can trigger the onLoadTileSet callback on the three.js implementation.

@gkjohnson
Copy link
Contributor Author

@liberostelios I'm nearly done adding support for external tile sets if this is still interesting to you.

@gkjohnson gkjohnson merged commit df507e2 into master Dec 10, 2020
@gkjohnson gkjohnson deleted the external-tilesets branch December 10, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for external tilesets
1 participant
@gkjohnson