Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing extension in import path #577

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

jailln
Copy link
Contributor

@jailln jailln commented Jun 7, 2024

Add missing js extension in import path causing the following issue when using 3d-tiles-renderer 0.3.33 in an external project:

ERROR in ./node_modules/3d-tiles-renderer/src/three/gltf/classes/StructualMetadata.js 4:0-72
Module not found: Error: Can't resolve './PropertyAttributeAccessor' in '/home/jailln/Documents/dev/itowns/node_modules/3d-tiles-renderer/src/three/gltf/classes'
Did you mean 'PropertyAttributeAccessor.js'?
BREAKING CHANGE: The request './PropertyAttributeAccessor' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '*.mjs' file, or a '*.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.
[...]

PS: Thanks for this great lib 馃檪

@gkjohnson
Copy link
Contributor

Great, thank you!

@gkjohnson gkjohnson merged commit 8f82926 into NASA-AMMOS:master Jun 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants