Issue #201: Yaml file schema verification now works on included yaml files #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nttoole
changed the title
nttoole
changed the title
nttoole
reviewed
Jul 27, 2022
nttoole
reviewed
Jul 27, 2022
nttoole
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue-201 Yaml file schema verification now works on included yaml files.
In the Validator class I renamed the validate() method validate_schema(). This is used in the unit test to validate evr.yaml, table.yaml and limits.yaml. It is only a general schema check.
I removed the individual validate() methods from the CmdValidator(Validator) and TlmValidator(Validator) classes and moved a general validate() function to the Validator class.
Added get_included_files() to the Validator class to produce a list of yaml files that need to be validated.
Fixes #201