Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFDP Class 2 NAK procedures #53

Merged
merged 7 commits into from
Oct 3, 2018
Merged

CFDP Class 2 NAK procedures #53

merged 7 commits into from
Oct 3, 2018

Conversation

lorsposto
Copy link
Contributor

Closes #47, closes #48

Work towards epic #52

  • Implementation of NAK procedures for Class 2 sender and receiver
  • Unit tests for NAK functionality, although complete Sender test implementation depends on ACK procedure implementation

@lorsposto lorsposto requested review from a team as code owners October 3, 2018 20:07
MJJoyce
MJJoyce approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@MJJoyce MJJoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MJJoyce MJJoyce merged commit 9a95cda into cfdp-c2 Oct 3, 2018
@lorsposto lorsposto deleted the cfdp-c2-r2-nak branch October 4, 2018 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MJJoyce MJJoyce MJJoyce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lorsposto @MJJoyce