Issue #5 - Implement BIND-level authentication #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 23, 2018 09:25
- Add credentials to config - Add credential algorithm
- update rcf/cltu examples
MJJoyce
requested changes
Apr 26, 2018
| spacecraft_id=250, | ||
| trans_frame_ver_num=1, | ||
| auth_level="bind", | ||
| peer_auth_level="bind" |
There was a problem hiding this comment.
We shouldn't need both of these. The auth level should cover outgoing/inbound auth in all 3 cases. I.e., 'Bind' level auth means the outgoing bind request is auth'ed and the receipt has auth info from the harness that we should decode
bliss/sle/cltu.py
Outdated
| @@ -148,8 +148,8 @@ def start(self): | |||
| ''' | |||
| start_invoc = CltuUserToProviderPdu() | |||
|
|
|||
| if self._credentials: | |||
| pass | |||
| if self._auth_level in ['all']: | |||
There was a problem hiding this comment.
Can we set this to be _auth_level == 'all' instead of doing membership checks?
| @@ -327,7 +327,29 @@ def decode(self, message): | |||
| def _bind_return_handler(self, pdu): | |||
| '''''' | |||
| result = pdu['cltuBindReturn']['result'] | |||
| responder_identifier = pdu['cltuBindReturn']['responderIdentifier'] | |||
There was a problem hiding this comment.
If this is the same across the 3 interfaces let's move the bulk of the logic to the common class between the 3. I realize there was probably a lot of duplication before as well though =)
MJJoyce
approved these changes
Apr 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5
config.yamlto include credential/auth level config