Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentifier tool vsicurl support #444

Merged

Conversation

Wieschie
Copy link
Contributor

@Wieschie Wieschie commented Oct 24, 2023

Purpose

  • This pull request modifies the IdentifierTool to add support for remote virtual layers through GDAL's vsicurl.

Proposed Changes

  • [CHANGE] Add special case handling for /vsicurl/ URLs to IdentifierTool. The 'getbands' API already fully supports this, so all that's needed is for the frontend to provide the proper URL.
  • [CHANGE] (optional): During testing, I noticed that the 'getbands' and 'getprofile' API endpoints return an empty 200 response if there is an error inside the script or invalid parameters are provided. I modified these to return a 400 and log the error if one occurs.

Testing

I've tested this PR with our local development environment. We have a WMS server that serves floating point geotiffs, and I created a gdal_wms.xml remote layer description file. The following simple Identifier Tool config works to retrieve point values from the remote layer.

{
    "layer_name": {
        "url": "/vsicurl/https://mapserver/static/gdal_wms.xml",
        "bands": 1,
    }
}

Copy link
Member

@tariqksoliman tariqksoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome and thank you!

@tariqksoliman tariqksoliman merged commit 27def3c into NASA-AMMOS:development Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants