#452 Updated Identifier tool to be a separated floating tool #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tariqksoliman
requested changes
Nov 13, 2023
- Need to test different UI combinations with other separated tools - We may possibly want an option to make the tool not be separated to maintain compatibility
Bug was causing other tools to not open. This makes it backwards compatible.
tariqksoliman
approved these changes
Apr 23, 2024
|
I added support to allow the Identifier and Legend tools to be on different sides if specified. We may need a more scalable though, if we enable more separated tools in the future. |
tariqksoliman
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Proposed Changes
Issues
Testing
Currently being used by one mission and works as expected with tools on the right-side of the UI
Clicking on tool icon activates tool, allows user to hover over data to see values, tool remains activated with Layer tool open and user switching between layers, clicking again on tool icon deactivates tool
Need to test different UI combinations with other separated tools
We may possibly want an option to make the tool not be separated to maintain compatibility