Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simulation events table panel #1236

Merged
merged 10 commits into from
May 7, 2024
Merged

Add simulation events table panel #1236

merged 10 commits into from
May 7, 2024

Conversation

mattdailis
Copy link
Collaborator

This PR adds a table for visualizing simulation events.

image

Some use cases that motivate this:

  • Emitting warnings from simulation. Sometimes an exception is too much, and a resource doesn't quite feel like the right tool
  • Logging information from the mission model to provide additional information about actions performed by an activity

This information is already captured in the database, but there isn't yet a way to visualize it.

Future work:

  • Associating events with the span in which they were emitted
  • Potentially visualizing these events on the timeline
  • Richer filtering, and perhaps providing some "log level" like customization and color coding
  • Related to that last point @duranb pointed out that logs might live naturally in the bottom console

@dandelany
Copy link
Collaborator

dandelany commented Apr 26, 2024

In our demos today, we got some user feedback from @parkerabercrombie that it would make more sense for these events to appear in the same place as the error console (accessible from the bottom bar) rather than a separate table in a panel. @mattdailis let me know if you'd like to include that change in this PR or if I should open a separate ticket.

@AaronPlave
Copy link
Contributor

In our demos today, we got some user feedback from @parkerabercrombie that it would make more sense for these events to appear in the same place as the error console (accessible from the bottom bar) rather than a separate table in a panel. @mattdailis let me know if you'd like to include that change in this PR or if I should open a separate ticket.

My guess is that this would require a small bit of discussion and design work to determine how this should live within the error console. I'd lean towards a followup PR but defer to whatever @mattdailis thinks.

@duranb
Copy link
Collaborator

duranb commented May 7, 2024

In our demos today, we got some user feedback from @parkerabercrombie that it would make more sense for these events to appear in the same place as the error console (accessible from the bottom bar) rather than a separate table in a panel. @mattdailis let me know if you'd like to include that change in this PR or if I should open a separate ticket.

My guess is that this would require a small bit of discussion and design work to determine how this should live within the error console. I'd lean towards a followup PR but defer to whatever @mattdailis thinks.

I second a followup PR. It might be good to get this out in front of more users as is so that they can give other feedback that we can also include in the followup.

@mattdailis mattdailis merged commit 8da1135 into develop May 7, 2024
5 checks passed
@mattdailis mattdailis deleted the event-view branch May 7, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants