[AERIE-1912] temporal object types don't transfer to worker #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyst5422
requested review from
patkenneally,
pcrosemurgy,
mattdailis,
goetzrrGit,
adrienmaillard,
camargo and
JoelCourtney
as code owners
dyst5422
changed the title
dyst5422
force-pushed
the
fix/AERIE-1912--temporal-object-types-dont-transfer
branch
from
b561c7b
to
7c91833
Compare
|
Rewrote the commit history to be clearer (there were some parts split between commits) |
dyst5422
force-pushed
the
fix/AERIE-1912--temporal-object-types-dont-transfer
branch
3 times, most recently
from
3533da2
to
4d3a46f
Compare
goetzrrGit
approved these changes
Jun 28, 2022
Move the test utilities around a bit for clarity
Add regression test for time serialization
The function findAndOrderCommandArguments in CommandEDSLPreface.ts is used in the generated code, but not in any code at compile time, so we need to add a comment so typescript knows to ignore that it
dyst5422
force-pushed
the
fix/AERIE-1912--temporal-object-types-dont-transfer
branch
from
4d3a46f
to
59c9cac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So because Temporal isn't yet into the spec, its not part of the structuredClone algorithm that is used when transferring data between workers (not sure if it ever will be in the structuredClone, but I would expect it to find its way in there when its formally brought into the spec).
The solution here is to serialize the Temporal objects before sending across to the worker, and deserialize on the worker.
I added two functions - one to serialize the Temporal objects in an object tree, and another to deserialize an object tree with Temporal objects.
Verification
There is the test added in the first commit for regression testing our worker, and a test with the change to actually test the serializer/deserializer.
Documentation
No documentation update needed
Future work
Add a test for durations/instants that are part of the attributes of an activity