[AERIE-1911] - Range check recurrence interval #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranav-super
requested review from
patkenneally,
pcrosemurgy,
mattdailis,
goetzrrGit,
dyst5422,
adrienmaillard,
camargo and
JoelCourtney
as code owners
mattdailis
reviewed
Jun 23, 2022
scheduler/src/main/java/gov/nasa/jpl/aerie/scheduler/goals/RecurrenceGoal.java
Outdated
Show resolved
Hide resolved
patkenneally
requested changes
Jun 24, 2022
scheduler/src/main/java/gov/nasa/jpl/aerie/scheduler/goals/RecurrenceGoal.java
Outdated
Show resolved
Hide resolved
scheduler/src/test/java/gov/nasa/jpl/aerie/scheduler/TestRecurrenceGoal.java
Outdated
Show resolved
Hide resolved
scheduler/src/main/java/gov/nasa/jpl/aerie/scheduler/goals/RecurrenceGoal.java
Outdated
Show resolved
Hide resolved
scheduler/src/main/java/gov/nasa/jpl/aerie/scheduler/goals/RecurrenceGoal.java
Show resolved
Hide resolved
pranav-super
force-pushed
the
feature/AERIE-1911--range-check-recurrence-interval
branch
3 times, most recently
from
6167879
to
03acf09
Compare
JoelCourtney
approved these changes
Jun 28, 2022
scheduler/src/main/java/gov/nasa/jpl/aerie/scheduler/goals/RecurrenceGoal.java
Outdated
Show resolved
Hide resolved
pranav-super
force-pushed
the
feature/AERIE-1911--range-check-recurrence-interval
branch
2 times, most recently
from
8dabd66
to
fb59945
Compare
patkenneally
approved these changes
Jul 7, 2022
pranav-super
force-pushed
the
feature/AERIE-1911--range-check-recurrence-interval
branch
from
fb59945
to
579708b
Compare
pranav-super
deleted the
feature/AERIE-1911--range-check-recurrence-interval
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The focus of the PR is to range check recurrence intervals, that is, not allow negative recurrence intervals. To do this, we catch the error within the builder of the
RecurrenceGoal(specifically infill()). Also, since the RecurrenceGoal stores its interval as a window (with the start representing a minimum recurrence interval, the end representing a maximum, a feature not yet supported), that was replaced with a recordMinMaxAllowableRecurrenceIntervaljust to make it more explicit.Verification
A new test was added to the existing recurrence goal tests - TestRecurrenceGoal.
Similarly, another test was added to the integration tests, to verify the entire process worked.
Documentation
Just an update to the recurrence goal section.
Future work
This might play weird with the AnalyzeWhen ([AERIE-1880]) PR, just because of the
MinMaxAllowableRecurrenceIntervalfix.