Update schema args as objects #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camargo
changed the title
camargo
added
breaking change
Converted number primitive to object in schema Converted primitive string to object in schema Updated generated types Updated version to 1.0.11
cohansen
force-pushed
the
feature/update-schema-args-as-objects
branch
from
4808705
to
51d1203
Compare
dyst5422
reviewed
Feb 3, 2023
camargo
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
LGTM! Let's get sign off from @goetzrrGit and this is good to merge.
goetzrrGit
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2.
This PR updates the 3 primitive types (
string,number, andboolean) forargsto objects.Hopefully I caught all the tests, there were quite a few that included the primitive types...