Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: weighted pixel area statistics #284

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

moradology
Copy link
Contributor

@moradology moradology commented Jan 30, 2024

This PR aims to provide tests for appropriate behavior of pixel-area-weighted statistics.

The basic idea behind this test is spelled out here

@moradology
Copy link
Contributor Author

It is looking as though I'm going to have to put in a bit of effort to get these integration tests to easily run locally. At the moment, the docker compose on our README is pretty inadequate for safely, conveniently verifying CI behavior

@j08lue
Copy link

j08lue commented Feb 1, 2024

At the moment, the docker compose on our README is pretty inadequate for safely, conveniently verifying CI behavior

Ah, please ticket that, @moradology.

@moradology
Copy link
Contributor Author

Issue lodged at #285

Copy link

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a relevant test to have in our test suite, I think, so we can sustain trust in the accuracy of our zonal statistics method.

Can we generate the test file on the fly, rather than loading it from cloud storage? Then the test code would include information about how the data is created together with the expected result, which would make it more helpful and avoid relying on some storage that might get abandoned or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants