Keep date visible on scrollytelling maps #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
danielfdsilva
force-pushed
the
feature/376-scrollytelling-date
branch
from
016926b
to
696716e
Compare
aboydnw
approved these changes
Jan 13, 2023
nerik
approved these changes
Jan 16, 2023
| @@ -37,6 +36,8 @@ import { MapLoading } from '$components/common/loading-skeleton'; | |||
| import { HintedError } from '$utils/hinted-error'; | |||
| import { formatSingleDate } from '$components/common/mapbox/utils'; | |||
| import { convertProjectionToMapbox } from '$components/common/mapbox/projection-selector/utils'; | |||
| import { useSlidingStickyHeaderProps } from '$components/common/layout-root'; | |||
| import { HERO_TRANSITION_DURATION } from '$components/analysis/page-hero-analysis'; | |||
There was a problem hiding this comment.
Maybe this const should not live under /analytics/ anymore.
There was a problem hiding this comment.
@nerik Addressed :)
| top: 4rem; | ||
| ${({ topOffset }) => css` | ||
| top: ${topOffset}px; | ||
| height: calc(100vh - ${topOffset}px); |
There was a problem hiding this comment.
Is that the equivalent of the following?:
top: ${({ topOffset }) => topOffset}px;
height: calc(100vh - ${({ topOffset }) => topOffset}px);
Not saying it's any better, but the styled components doc makes it confusing to me
There was a problem hiding this comment.
Yup. Absolutely the same, but I prefer the other approach.
I like that within a styled-component the functions return css. In this way I could extract all that into a separate function if needed. For me this approach also makes it more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the date remains visible by changing the scrollytelling block offset when the header is visible #376