Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIGOS related updates, new gage processing, and some bug fixes #1449

Merged
merged 46 commits into from
Dec 12, 2023
Merged

WIGOS related updates, new gage processing, and some bug fixes #1449

merged 46 commits into from
Dec 12, 2023

Conversation

emkemp
Copy link
Contributor

@emkemp emkemp commented Nov 15, 2023

Description

  • Added support for global (and WIGOS compliant) sfcsno files in USAFSI
  • Added support for global (and WIGOS compliant) preobs files in NAFPA
  • Added new gage processing library in NAFPA
  • Added support for global (and WIGOS compliant) sfcobs files in LIS AGRMET
  • Modified numerous write statements to add [INFO], [WARN], or [ERR] tag
  • Modified several write statements to trim character variables before output
  • Initialized certain arrays to zero immediately after allocation
  • Corrected variable type of QC flags (were real, now are integer)
  • Changed some if statements to avoid "equals" checks of real variables (considered bad practice)
  • Added some checks and error handling of status codes from MPI calls
  • Fixed preprocessing bug in RAPID_routing_run.F90 (call to RAPID_model_main must be wrapped by #ifdef PETSc)

emkemp added 30 commits July 28, 2023 10:49
@emkemp
Added new sfcobs format with longer station IDs.
dde02d2
@emkemp
Changed "new" sfcsno file format to global file. Station IDs now 32 c…
aa84801 
…hars.
@emkemp
First import of new gage processing code.
a2208e9 
Needs to be integrated into LIS-AGRMET.
@emkemp
Added imports to LIS_logMod.F90.
06a39eb
@emkemp
Removed rootdir argument.
2ee11bc
@emkemp
LIS now uses new gage code. Station and network ID now 32 characters …
149157c 
…long.

NOTE:  Have noticed Bratseth temperature analyses now change from run
to run.  Occurs with both Intel and GNU compilers with debugging flags.
Does not appear to happen with support/lisf-557ww-7.5 branch, nor with
master branch.  Will investigate earlier commits to see if cause can be
determined.
@emkemp
Forgot to add a new file.
1147d0a
@emkemp
Again, added missing file.
482777f
@emkemp
Removed file that was committed in wrong directory.
d07c1f7 
It already exists elsewhere.
@emkemp
Merge branch 'master' into feature/newobs_format
e097fe5
@emkemp
Added MPI error checks. Also added some debugging print statements.
22e83d7
@emkemp
Corrected QC flag data types. Changes to avoid direct check of real z…
a4f6f92 
…eros.
@emkemp
Added initialization after array allocations.
20af729 
Valgrind complained that the lack of immediate initialization caused
problems later in the LIS execution.  I'm skeptical, but it is known
that Linux doesn't finish allocation until a program starts writing
to the "allocated" memory.  So this is not a bad idea in general.
@emkemp
Added alert files if problem occurs with preobs or presav2 file.
44fb0e5
@emkemp
Added support for new (WIGOS-friendly) sfcobs files.
35bb01e
@emkemp
Added alert files for problems with sfcobs files.
724760a
@emkemp
Removed dead code.
7efec4b
@emkemp
Tweaked code so first alert message for preobs is 001, not 000.
8ff8de6
@emkemp
Added info print statements.
f763b35
@emkemp
Commented out debugging print statement.
3f53f28
@emkemp
Tweaked info print statements.
d8e98a0
@emkemp
Revised logic to only read presav2 file at synoptic hour.
a31f607
@emkemp
Tweaked output (character variable is now trimmed).
bdc5993
@emkemp
Warning message now marked with "[INFO]", which is more appropriate.
5cabc04
@emkemp
Added [INFO], [WARN], and [ERR] tags to write statements.
db3efb0
@emkemp
Added [INFO] tag to write statements.
260cda6
@emkemp
Added [INFO] tag to write statements.
33c2bea
@emkemp
Added [INFO] tag to write statement.
9116ce5
@emkemp
Added [INFO] tag to write statement.
624349f
@emkemp
Added [INFO] and [WARN] tags to write statements.
9975cdb
@emkemp
Added [INFO] tag to write statement.
8ee2cfa
@emkemp
Tweaked write statement to indicate line from sfcobs file is skipped.
d9d83a1
@emkemp
Added [INFO] and [WARN] tags to write statements.
d647210
@emkemp
Added [INFO] and [ERR] tags to write statements.
331b98b
@emkemp
Added [INFO] and [ERR] tags to write statements.
7589950
@emkemp
Added [INFO] and [ERR] tags to write statements.
6683637
@emkemp
Added [INFO] and [ERR] tags to write statements.
6fd32bd
@emkemp
Added [INFO] tag to write statement.
616046b
@emkemp
Added [INFO] and [WARN] tags to write statements.
a00da2f
@emkemp
Added [INFO], [WARN], and [ERR] tags to write statements.
fb38d50
@emkemp
Added [INFO] and [ERR] tags to write statements.
8777cc1
@emkemp
Added [INFO] and [ERR] tags to write statements.
360fc05
@emkemp
Added [INFO] tag and trimmed character variable in write statement.
971c6ef
@emkemp
Added [INFO] tag to write statement.
4628f2e
@emkemp emkemp added enhancement New feature or request LISF 557WW 7.6 labels Nov 15, 2023
@jvgeiger jvgeiger merged commit 2412656 into NASA-LIS:master Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request LISF 557WW 7.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emkemp @jvgeiger