Check that the LID for a collection product has the LID of its parent bundle as its base

[jordanpadams]

L5.PRP.VA.30 - Check that the LID for a collection product has the LID of its parent bundle as its base. Only applies to primary objects.

Per Richard Chen:

The document collection has a LID that doesn't match the bundle LID but validate passes it. That's probably enough to reopen this, plus I don't see how to attach a file to a closed issue.

The attached dir has many errors - sorry, I'm too tired to pare those down. One error not caught is that the bundle has LID urn:nasa:pds:phx_ra while its document collection has LID urn:nasa:pds:phx_ra_605typo:document, and requirement L5.PRP.VA.30 asks exactly for validate to check that.

bundleLID.zip

[hhlee445]

@richardchenca Richard, can you point me to the data set you tested for this issue?

[jordanpadams]

@hhlee445 @richardchenca I tracked this back to JIRA and attached the example. Also per JIRA, this appears to be a bug fix associated with https://osr.jpl.nasa.gov/jira/browse/PDS-605, which was committed per https://github.jpl.nasa.gov/PDSEN/pds4-java/pull/55/ .

it appears to fail in the bundle.xml, but the collection.xml passes (which it shouldn't):

  PASS: file:/Users/jpadams/Documents/proj/pds/pdsen/workspace/validate/bundleLID/document/collection_1.xml

  FAIL: file:/Users/jpadams/Documents/proj/pds/pdsen/workspace/validate/bundleLID/bundle_1.xml
      WARNING  [warning.integrity.member_not_found]   The member 'urn:nasa:pds:phx_ra:data_test' could not be found in any product within the given target.
      WARNING  [warning.integrity.member_not_found]   The member 'urn:nasa:pds:phx_ra:context' could not be found in any product within the given target.
      ERROR  [error.integrity.missing_parent_prefix]   Member LID urn:nasa:pds:phx_ra_605typo:document does not begin with required parent LID urn:nasa:pds:phx_ra

[hhlee445]

@jordanpadams The collection.xml passes because the member status of the collection is set to 'S' (secondary). Current validate tool only verify LID Prefix while the member status of the bundle is set to 'Primary'. Should we verify LID Prefix for both 'Primary' (P) and 'Secondary' (S)? What is the difference of 'Primary' and 'Secondary'?

[richardchenca]

Hmm, I can't vpn in now. If primary, column 2 must be a LIDVID If secondary, it can be a LID or a LIDVID. I think, with maybe 70% confidence, that the file need not be there. On 3/23/20, 18:28, "Hyun Lee" <notifications@github.com> wrote: @jordanpadams <https://github.com/jordanpadams> The collection.xml passes because the member status of the collection is set to 'S' (secondary). Current validate tool only verify LID Prefix while the member status of the bundle is set to 'Primary'. Should we verify LID Prefix for both 'Primary' (P) and 'Secondary' (S)? What is the difference of 'Primary' and 'Secondary'? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMK4NJMODD5MVFH3O5DINIDRJAEEJANCNFSM4H3BQ7SQ>. [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#10 (comment)", "url": "#10 (comment)", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

[jordanpadams]

@hhlee445 does the software first go find the collection and then check for the LID prefix? Or does it do it when it is checking the bundle.xml?

If it is the latter, let's check it. If it doesn't check until it opens up the collection.xml, then let's just ignore that since that product would have never passed validation in the first place to become a primary object.

[jordanpadams]

@hhlee445 any status on completing testing for this?

[jordanpadams]

Closed as wontfix per #10 (comment)