Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L5.PRP.VA.42 The tool shall average less than 1 second execution time when content validation is disabled. #124

Closed
jordanpadams opened this issue Oct 4, 2019 · 2 comments · Fixed by #152
Assignees
Labels
enhancement New feature or request Epic

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Oct 4, 2019

Our current benchmarks (see below) still take 10 minutes for large files (GBs) and 4-8 seconds for smaller files (MBs). This is a significant improvement from before, but deliveries involve thousands of products, so validate is still taking days instead of hours to run on one delivery. We need to figure out where else we can improve performance.

This new requirements is specific to improving all parts of validation separate from content validation.

Large test data sets are on pds-dev-el7:/path/to/test/data/insight_cameras

Screen Shot 2019-10-04 at 9 37 00 AM

NOTE: You may need to execute with a catalog file or against multiple products to see improved performance. The initial loading of schemas/going out to internet will always take some time.

@jordanpadams jordanpadams added this to the PDS.01 (ends 2019-10-09) milestone Oct 4, 2019
@jordanpadams jordanpadams changed the title Validation performance improvements (Phase 2): Label Validation Improvements L5.PRP.VA.42 The tool shall average less than 1 second execution time when content validation is disabled. Oct 4, 2019
@jordanpadams jordanpadams added the requirement New requirements label Oct 8, 2019
@hhlee445
Copy link
Contributor

hhlee445 commented Oct 9, 2019

@jordanpadams Jordan, can you give exact path of the test data you indicated in the description?

@hhlee445
Copy link
Contributor

hhlee445 commented Nov 7, 2019

Before adding a command chain, time command returns
11.675u 0.557s 0:04.00 305.5% 0+0k 0+0io 0pf+0w

After adding 'pds4.label.skip.content' command chain, time command returns
11.373u 0.561s 0:03.79 314.7% 0+0k 0+0io 0pf+0w

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Epic
Projects
None yet
2 participants