Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validated product counter to pass/fail reporting and end summary #132

Closed
jordanpadams opened this issue Oct 8, 2019 · 3 comments · Fixed by #191
Closed

Add validated product counter to pass/fail reporting and end summary #132

jordanpadams opened this issue Oct 8, 2019 · 3 comments · Fixed by #191
Assignees
@hhlee445
Labels
enhancement New feature or request Epic
Milestone
PDS.13 (ends 2020...

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Oct 8, 2019 •
edited

Per conversations with GEO and RMS, a counter should be added to pass/fail report dialog to include a counter (validated/to go) in order to be able to monitor status. In addition, in the final output summary, the old VTool included a "validated" number at the end report to show successful validated products
@jordanpadams jordanpadams added enhancement New feature or request triage-needed labels Oct 8, 2019
@jordanpadams jordanpadams changed the title Add successful validation count to end report Add validated product counter to report and end summary Oct 9, 2019
@jordanpadams jordanpadams changed the title Add validated product counter to report and end summary Add validated product counter to pass/fail reporting and end summary Oct 9, 2019
@jordanpadams jordanpadams added this to the PDS.08 (ends 2020-01-15) milestone Dec 13, 2019
@hhlee445
Copy link
Contributor

hhlee445 commented Mar 7, 2020

Added a section in the end summary as:

Number of Passed product(s)/folder(s): 1
Number of Failed product(s)/folder(s): 4
Number of Skipped product(s)/folder(s): 0
Total Number of product(s)/folder(s): 5

@hhlee445 hhlee445 closed this as completed Mar 7, 2020
@jordanpadams
Copy link
Member Author

Reopening for now until PR has been merged

@jordanpadams jordanpadams reopened this Mar 7, 2020
@hhlee445
Copy link
Contributor

Modified to have the count of product only.

Number of Passed product(s): 1
Number of Failed product(s): 4
Number of Skipped product(s): 0
Number of Total product(s): 5

@hhlee445 hhlee445 mentioned this issue Mar 19, 2020
Merged
@jordanpadams jordanpadams reopened this Mar 19, 2020
jordanpadams added a commit that referenced this issue Mar 22, 2020
@hhlee445 @jordanpadams
Add validated product counter to pass/fail reporting and end summary (#…
9791443 
…191)

* issue_132: Add validated product counter to pass/fail reporting and end summary

* issue_132: remove unnecessary code

* issue_32: Number only contains the products' count (excluding folders)

* Updating license information

* Improve usability of report outputs

"targets" and "products" can be a bit confusing when being used synonymously
with validation checks.

First attempt at trying to clarify that. Let's see who hates it.

Refs #132 

Co-authored-by: Jordan Padams <jordan.h.padams@jpl.nasa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hhlee445 hhlee445

Labels
enhancement New feature or request Epic
Projects
None yet
Milestone
PDS.13 (ends 2020-03-25)
Development

Successfully merging a pull request may close this issue.

Add validated product counter to pass/fail reporting and end summary NASA-PDS/validate
2 participants
@jordanpadams @hhlee445