Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a temp dir instead of an unlinked temp file and fix arg to calling process on aipgen
Summary
Previously, we were using
NamedTemporaryFile
to make a temporary file forsqlite3
.sqlite3
would close and open this file several times during processing. On Unix, this is fine. On Windows NT or later, the very first "close" on the file would render it unusable by future opens. So instead, we make a temporary directory instead of a file and use a known filename inside of that (#77).Also, we noticed that there was a redundant
args.
being referenced in the call toprocess
inaip.py
. This fixes that (#78).Test Data and/or Report
Related Issues