Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #77 and #78 #79

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Resolve #77 and #78 #79

merged 1 commit into from
Oct 2, 2020

Conversation

nutjob4life
Copy link
Member

Use a temp dir instead of an unlinked temp file and fix arg to calling process on aipgen

Summary

Previously, we were using NamedTemporaryFile to make a temporary file for sqlite3. sqlite3 would close and open this file several times during processing. On Unix, this is fine. On Windows NT or later, the very first "close" on the file would render it unusable by future opens. So instead, we make a temporary directory instead of a file and use a known filename inside of that (#77).

Also, we noticed that there was a redundant args. being referenced in the call to process in aip.py. This fixes that (#78).

Test Data and/or Report

Running tests at level 1
Running zope.testrunner.layer.UnitTests tests:
  Set up zope.testrunner.layer.UnitTests in 0.000 seconds.
  Running:
    10/13 (76.9%) test_logging_arguments (pds.aipgen.tests.test_utils.ArgumentTestCase)usage: 
                                                                                            
  Ran 13 tests with 0 failures, 0 errors, 0 skipped in 0.763 seconds.
Tearing down left over layers:
  Tear down zope.testrunner.layer.UnitTests in 0.000 seconds.

Related Issues

… fix arg to calling process on aipgen

Previously, we were using `NamedTemporaryFile` to make a temporary file for `sqlite3`. `sqlite3` would close and open this file several times during processing. On Unix, this is fine. On Windows NT or later, the very first "close" on the file would render it unusable by future opens. So instead, we make a temporary _directory_ instead of a file and use a known filename inside of that (#77).

Also, we noticed that there was a redundant `args.` being referenced in the call to `process` in `aip.py`. This fixes that (#78).
@jordanpadams jordanpadams merged commit 21bd5c7 into master Oct 2, 2020
@jordanpadams jordanpadams deleted the windows+argument branch October 2, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants