Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default keywords/subjects are not always added to DOI records #273

Closed
collinss-jpl opened this issue Oct 13, 2021 · 1 comment · Fixed by #293
Closed

Default keywords/subjects are not always added to DOI records #273

collinss-jpl opened this issue Oct 13, 2021 · 1 comment · Fixed by #293
Assignees
Labels
B12.1 bug Something isn't working s.medium
Milestone

Comments

@collinss-jpl
Copy link
Contributor

collinss-jpl commented Oct 13, 2021

🐛 Describe the bug

The DOI service provides a configuration setting to specify one or more keywords/subjects to include with every DOI record minted by the service. However, this field is not used, and default keywords are only added when a DOI record is created from a PDS4 label. The service needs to ensure the default keywords are also present for records created from spreadsheets or DataCite JSON labels.

📜 To Reproduce

Steps to reproduce the behavior:

  1. Ensure the INI config for the service defines a comma-delimited list of values for OTHER.global_keyword_values (typically PDS,PDS4)
  2. Submit a reserve request using a valid XLS, CSV or DataCite JSON label (that does not already contain expected default keywords)
  3. Observe that the DataCite JSON label returned does not contain the expected default keywords defined by the INI config

🕵️ Expected behavior

The DOI record returned from a reserve, update or release request should always include a "subjects" field which contains, at minimum, the values specified in the OTHER.global_keyword_values section of the INI config.

📚 Version of Software Used

v2.0.1

🩺 Test Data / Additional context

🏞Screenshots

🖥 System Info

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

🦄 Related requirements

⚙️ Engineering Details

@jpl-jengelke
Copy link

jpl-jengelke commented Aug 8, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B12.1 bug Something isn't working s.medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants