Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spreadsheet parsers do not handle blank rows gracefully #291

Closed
collinss-jpl opened this issue Nov 4, 2021 · 0 comments · Fixed by #292
Closed

Spreadsheet parsers do not handle blank rows gracefully #291

collinss-jpl opened this issue Nov 4, 2021 · 0 comments · Fixed by #292
Assignees
Labels
B12.1 bug Something isn't working i&t.skip s.low
Milestone

Comments

@collinss-jpl
Copy link
Contributor

🐛 Describe the bug

Providing a spreadsheet file (CSV or XLS) as input with one or more blank rows can cause unhelpful exceptions to be raised. The service should be able to process or skip blank rows without raising an error.

📜 To Reproduce

Steps to reproduce the behavior:

  1. Submit the attached XLS spreadsheet to the service via the reserve action
  2. Observe that the following exception is raised: pds_doi_service.core.input.exceptions.CriticalDOIException: 'NaTType' object has no attribute 'lower'

🕵️ Expected behavior

Service should process the spreadsheet with blank rows without raising an exception.

📚 Version of Software Used

v2.1.0

🩺 Test Data / Additional context

DOI_reserve_M2020_IMG_Release2_v2.xlsx

🏞Screenshots

🖥 System Info

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

🦄 Related requirements

⚙️ Engineering Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B12.1 bug Something isn't working i&t.skip s.low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants