-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate the submitted OSTI record against a schema #56
Comments
Add a private method to the schematron_validator (osti_validator): _validate_schema(). Add a call to this method in the public validate() method. |
New XSD and schema: |
…ng, add code to compare DOIs, modify config for correctness to OSTI version, modify feature files for ease of search, add implementation in steps.py, add keyword as parameter to 'draft' action, fix bug in 'reserve' action if exception occurred due to issue with 'title', add writing of output files to 'draft' unit tests, add logic when first_name and last_name are swapped by user, fix bug with missing InputFormatException in osti_web_parser.py
Comments on the schema:
|
After feedback from @ron and @jordanpadams Jordan, decision to resolve discrepancies between current DOI output and schema are:
@qchaupds, you should implement the necessary code updates for empty tag management in the object which read and write doi object from osti record format. This might also have an impact on the verification rule, hopefully not. |
…lidation, modify templates for 'reserve' and 'draft' to conform to XSD, add config for XSD file, modify features files for 'behave' testing, modify steps.py to match feature verbiage, fix bug with input to 'release' to contain URN instead of URL, add XSD validation to 'draft', 'release' and 'reserve', fix reserve_test.py to conform to new parameters, remove date check with schematron from osti_input_validator.py as XSD would of caught it, add 'date_record_added' to DOI as XSD requires it, add function create_osti_doi_release_record to osti.py, add parsing of 'authors' field in osti_web_parser.py if found, add XSD valildation to doi_validator.py and fix bug with accesing 'doi' fields that are None, modify doi_xml_differ.py logic to handle 'id', 'date_record_added' and clean up print statements.
… and 'reserve' features. Fix bug with parsing for 'modification_date' when more than one is available, fix bug with 'first_name' and 'last_name' when leading spaces exist, add safeguard when 'publication_date' is string instead of datetime, add parsing of 'product_nos' when 'identifier_value' is not available for some DOI in doi_xml_differ.py
…ng, add code to compare DOIs, modify config for correctness to OSTI version, modify feature files for ease of search, add implementation in steps.py, add keyword as parameter to 'draft' action, fix bug in 'reserve' action if exception occurred due to issue with 'title', add writing of output files to 'draft' unit tests, add logic when first_name and last_name are swapped by user, fix bug with missing InputFormatException in osti_web_parser.py
…lidation, modify templates for 'reserve' and 'draft' to conform to XSD, add config for XSD file, modify features files for 'behave' testing, modify steps.py to match feature verbiage, fix bug with input to 'release' to contain URN instead of URL, add XSD validation to 'draft', 'release' and 'reserve', fix reserve_test.py to conform to new parameters, remove date check with schematron from osti_input_validator.py as XSD would of caught it, add 'date_record_added' to DOI as XSD requires it, add function create_osti_doi_release_record to osti.py, add parsing of 'authors' field in osti_web_parser.py if found, add XSD valildation to doi_validator.py and fix bug with accesing 'doi' fields that are None, modify doi_xml_differ.py logic to handle 'id', 'date_record_added' and clean up print statements.
Plug the OSTI schema updated by Ron in the code at the DOI validation step.
See comments for schema to use.
The text was updated successfully, but these errors were encountered: