Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create full_name when first/last name cannot be parsed #58

Closed
tloubrieu-jpl opened this issue Aug 13, 2020 · 1 comment
Closed

create full_name when first/last name cannot be parsed #58

tloubrieu-jpl opened this issue Aug 13, 2020 · 1 comment
Assignees
@qchaupds
Labels
enhancement New feature or request
Milestone
PDS.24 (ends 2020...

Comments

@tloubrieu-jpl
Copy link
Member

Do that when we draft the osti record
@qchaupds
Copy link

This is a good thing because OSTI will reject any DOI with the first name as a blank (as is currently doing). Creating a full_name field will resolve this issue if it ever happens.

qchaupds pushed a commit that referenced this issue Aug 17, 2020
Changes to support issues #55 and #58: Update templates for 'reserve'…
0696a08 
… and 'draft' to add 'full_name', update 'URL' to 'URN' and 'Cites' to 'IsIdenticalTo', make 'Dataset' default for 'product_type' field, correct input artifacts to match requirement, update pds4_util to correctly 'product_type_specific' field and add 'full_name' field when cannot parse name, fix bug in osti_web_parser when 'identifier_type' changed from 'URL to 'URN', fix bug in doi_validator to fetch correct token to check for 'title' field, fix bug in emailer by adding quit() function to close resources, updaet stale comments in test suite doi_validator_test to match function's intention.
@qchaupds qchaupds mentioned this issue Aug 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qchaupds qchaupds

Labels
enhancement New feature or request
Projects
None yet
Milestone
PDS.24 (ends 2020-08-26)
Development

No branches or pull requests
2 participants
@tloubrieu-jpl @qchaupds