PDS DOI Service Dockerization #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 13, 2021 11:56
…arsed as XML during a draft POST request and cause an error JSON is now explicitly checked for when providing a requestBody for draft actions, and an exception is raised if present
…containerized context The parser instance created by DOIConfigUtil.get_config() is now cached (memorized) to prevent redundant processing of the INI. The config parser instance itself is now a specialized version of ConfigParser designed to prioritize expected environment variables over the INI values. This allows configuration options to be easily injected into the service when launching via Docker.
…ized service via docker-compose
nutjob4life
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
This looks pretty snazzy to me. +1. I say 🚢 it. What say you @tloubrieu-jpl?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the configuration files and code updates to support containerization of the PDS DOI Service via Docker.
A Docker image can now be built for the DOI service by running
docker build --tag pds-doi-service .from the root of the repo. The container can be launched viadocker-compose up. The API can then be reached vialocalhost:8080/PDS_APIs/pds_doi_api/0.1/ui/as usual.To support injection of configuration parameters, such as OSTI credentials, a
doi_service.envfile is utilized from within thedocker-compose.ymlto pass in options as environment variables. The INI config parser used by the DOI Service has also been modified to search the environment for expected options before falling back to what is in the INI.Test Data and/or Report
A unit test has been added for the new config parsing behavior.
test.txt
Related Issues