Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create command to add version label to open bugs #4

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Conversation

tloubrieu-jpl
Copy link
Member

@tloubrieu-jpl tloubrieu-jpl commented Nov 2, 2023

So to be used as search criteria for the known bugs of a release.

Search links with these criteria will be added to the release notes.

🗒️ Summary

Brief summary of changes if not sufficiently described by commit messages.

⚙️ Test Data and/or Report

One of the following should be included here:

  • Reference to regression test included in code (preferred wherever reasonable)
  • Attach test data here + outputs of tests

♻️ Related Issues

…h criteria for the known bugs of a release
@tloubrieu-jpl tloubrieu-jpl requested a review from a team as a code owner November 2, 2023 19:38
@jordanpadams
Copy link
Member

@tloubrieu-jpl to clarify, we just want to see what bugs are still open at time of release? I am OK with this, but these issues we intentionally keep open because they are low severity/priority are going to get a little busy with labels over time :-)

src/lasso/issues/argparse.py Show resolved Hide resolved

@param repo: repository from the github3 api
@param label_name:
@return:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No return value? We can delete this @return comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

The label need to be created first.

@param repo: repository from the github3 api
@param label_name:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have some text after label_name:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


if __name__ == "__main__":
main()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP8 recommends deleting the 6 blank lines

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines deleted.

src/lasso/issues/issues/add_version_label_to_open_bugs.py Outdated Show resolved Hide resolved
@tloubrieu-jpl tloubrieu-jpl merged commit 034d248 into main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a software user, I want to see the known bugs for a component release
3 participants