Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements per initial implementation of mockups #48

Closed
8 tasks done
jordanpadams opened this issue May 27, 2021 · 3 comments
Closed
8 tasks done

Enhancements per initial implementation of mockups #48

jordanpadams opened this issue May 27, 2021 · 3 comments
Assignees
Labels
B12.0 enhancement New feature or request

Comments

@jordanpadams
Copy link
Member

jordanpadams commented May 27, 2021

Here some updates to be implemented to the initial dev completed for #44

  • Change “Get URL” to “Upload Label”
  • Add "Upload Label" button next to text box
  • "Save" and "Submit for Review" buttons side-by-side
  • Add DOI(s) returned from Reserve step to output message
  • Update API requests per latest changes to https://miro.com/app/board/o9J_lF_ReJo=/
    • Save button -> POST /dois with action=draft
    • Submit for Review button -> POST /dois with action=draft AND POST /dois/{lidvid}/submit to submit for review
  • Update "Nodes" dropdown to be "Node" (the dropdown contains all the nodes, but the user is inputting their Node)
@jordanpadams jordanpadams added enhancement New feature or request sprint-backlog labels May 27, 2021
@jordanpadams jordanpadams added this to the 08.Joan.Benoit milestone May 27, 2021
@c-suh
Copy link
Contributor

c-suh commented May 27, 2021

@jordanpadams, I addressed a few of these items in my most recent push to branch issue-44:

  • Add DOI(s) returned from Reserve step to output message
  • Update API requests per latest changes to https://miro.com/app/board/o9J_lF_ReJo=/
    • Save button -> POST /dois with action=draft
    • Submit for Review button -> POST /dois with action=draft AND POST /dois/{lidvid}/submit to submit for review
  1. For the first bullet point, however, please note that the link will not work until we have URL handling implemented for the different "pages". I imagine that you would also like to change the wording/presentation of the information in the green box:
    Screen Shot 2021-05-26 at 6 19 45 PM

  2. For the second and third items in the main description above, how does this affect the placement of the "Ignore warnings" checkbox?

@jordanpadams
Copy link
Member Author

@c-suh

For the first bullet point, however, please note that the link will not work until we have URL handling implemented for the different "pages". I imagine that you would also like to change the wording/presentation of the information in the green box:

This looks good to me.

For the second and third items in the main description above, how does this affect the placement of the "Ignore warnings" checkbox?

I think we can leave it as-is for now below the Upload button (or we can move it to the right?). I'm still now sure how we want to handle that checkbox and when that should appear, so that may change down the road anyways.

@jordanpadams
Copy link
Member Author

@c-suh FYI, updated a couple things in the original description, and move the help stuff to a separate ticket we will try to tackle later on

c-suh pushed a commit that referenced this issue Jun 4, 2021
- Change 'Get URL' to 'Upload Label'
- Move 'Upload Label' button inline to input field
- Update 'Nodes' dropdown to 'Node'
- Move 'Save' and 'Submit for Review' buttons to be inline
- Rearrange placement and handling of the buttons above and their error
  messsages

Resolves #48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B12.0 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants