Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCB-256: Need method for providing permissible value definitions for external namespaces in Ingest_LDD #130

Closed
jshughes opened this issue Jan 24, 2020 · 5 comments · Fixed by #151
Assignees
Labels
pending-scr Approved SCR queued for implementation

Comments

@jshughes
Copy link
Collaborator

https://pds-jira.jpl.nasa.gov/browse/CCB-256
CCB-256.pdf

@jshughes jshughes added the pending-scr Approved SCR queued for implementation label Jan 24, 2020
@jshughes jshughes self-assigned this Jan 24, 2020
jshughes added a commit that referenced this issue Jan 24, 2020
…paces in Ingest_LDD

Enable LDDTool to create the Schematron rules needed to enforce the permissible value list as well as documenting the definitions of those values.

						Resolves #130
						Refs CCB-256
@rchenatjpl
Copy link

I followed SPmockup.txt in pds-jira...CCB-256, which constrains the values of local_reference_type to spectral_characteristics_to_array_object and something else. However, when I run lddtool -plM on the attached input file, the resulting .sch has nothing about local_reference_type. It is easily possible that I've done something wrong, but i don't know what.

% lddtool -plM ccb256lddtoolinput.xml

info - LDDTOOL Version: 11.0.0
info - IM Version Id: 1.14.0.0
info - IM Namespace Id: pds
info - IM Label Version Id: 1.20
info - Date: Sun Mar 08 11:25:25 PDT 2020
info - JAVAHOME: /Library/Java/JavaVirtualMachines/jdk-12.0.1.jdk/Contents/Home
info - PARENT_DIR: /PDS4tools/lddtool
info - SCRIPT_DIR: /PDS4tools/lddtool/bin
info - LIB_DIR: /PDS4tools/lddtool/lib

warning - Class omitted from build - Class Identifier:0001_NASA_PDS_1.pds.Schematron_Rule
warning - Class omitted from build - Class Identifier:0001_NASA_PDS_1.pds.Schematron_Assert
info - getMasterObjectDict - Found LDDToolSingletonClass - DMDocument.LDDToolSingletonDOMClass.title:Mission_Area
WARNING Init: - Config.Properties Namespace Id Not Found:insight
INFO Init: - Config.Properties Namespace Id Using:pds
WARNING Header: - New steward has been specified:geo
WARNING Header: - New namespace id has been specified:insight
info - LDDTOOL Exit
info - Exit

PDS4_INSIGHT_1E00_1E00.sch.zip

ccb256lddtoolinput.xml.zip

@rchenatjpl rchenatjpl reopened this Mar 8, 2020
@rchenatjpl
Copy link

The attached file doesn't validate. It's the same attachment at before with something else cleaned up. I guess the fix is to add DD_Associate_External_Class after DD_Association and DD_Association_External

Or maybe nobody validates such files, i.e. they just run lddtool on them without first validating the lddtool input files

ccb256lddtoolinput.xml.zip

jshughes added a commit that referenced this issue Mar 12, 2020
The Common (pds) schema is missing <DD_Associate_External_Class> in the <DD_Class> definition.

Resolves #130
Refs CCB-256
jshughes added a commit that referenced this issue Mar 12, 2020
…151)

The Common (pds) schema is missing <DD_Associate_External_Class> in the <DD_Class> definition.

Resolves #130
Refs CCB-256
@rchenatjpl rchenatjpl reopened this Mar 19, 2020
@rchenatjpl
Copy link

The attached file ccb256lddtoolinput.xml now validates, which is good. The .xsd that lddtool creates from it looks good. However, the .sch has no restrictions on the element with the external namespace. It is very possible that ccb256lddtoolinput.xml is incorrect. But what should it look like?
Archive.zip

jshughes added a commit that referenced this issue Mar 23, 2020
…matron file.

Bugfix - The new permissible values are not being written to the Schematron file. Also cleaned up Directory Stack output to allow full input file name.

						Resolves #130
						Refs CCB-256
@rchenatjpl
Copy link

I still can't get this to work. The Archive.zip I attached earlier has a DD_Associate_External_Class that includes DD_Permissible_Values, but those values are not showing up in the .sch that lddtool outputs. Can you tell me what's wrong with the input file ccb256lddtoolinput.xml or give me an example that works? Thanks.

@rchenatjpl rchenatjpl reopened this Apr 7, 2020
@rchenatjpl rchenatjpl reopened this Apr 7, 2020
@rchenatjpl
Copy link

grr, the stuff that looks like code in the middle of the last comment is just straight text that github is formatting.

jshughes added a commit that referenced this issue Apr 8, 2020
…values in external namespaces

LDDTool writing wrong type of Rule to validate attribute permissible values in external namespaces. Changed rule type from "EVERY" to "RAW. Also fixed Docbook formatting bug.

						Resolves #130
						Refs CCB-256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-scr Approved SCR queued for implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants