Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with DD_Associate_External_Class when trying to reference pds:Internal_Reference and pds:Local_Internal_Reference #391

Closed
jordanpadams opened this issue Jul 26, 2021 · 0 comments · Fixed by #394
Assignees
Labels

Comments

@jordanpadams
Copy link
Member

🐛 Describe the bug

From @anne-raugh

Found a bug in the released LDDTool v. 13.0.2 while helping Susie Slavney troubleshoot a problem with the Mars2020 dictionary she was on deadline for.

The problem is with the DD_Associate_External_Class, which she was trying to use to reference pds:Internal_Reference and pds:Local_Internal_Reference. The problem is that the output class and reference_type names are mangled - they are concatenations of the parent and pds: class and attribute names, which is not what they're supposed to look like.

I've attached a zip file with the following:

  • ddaecLDD.xml - A short Ingest_LDD file to demo the problem.
  • PDS4_TESTDDAEC_1G00_13.0.2.* - Output .sch and .xsd files from the released lddtool version 13.0.2, which show the naming problems in both files.
  • PDS4_TESTDDAEC_1G00_snapshot.* - Output .sch and .xsd files created using the 13.1.0 snapshot dated 2021-07-08 (the one I've been using for testing), which do not show the naming problems.
    Susie was trying to use DD_Associate_External_Class because apparently the word has gone out that that is what should be used, but it is not usable with the current released LDDTool and she was understandably reticent to use a snapshot version to build a delivery dictionary.

If other people are expecting that class to be usable with the current release of LDDTool, then this problem is fairly urgent. If there's paperwork you'd like me to file with JIRA, say the word.

🕵️ Expected behavior

Generated successfully.

📚 Version of Software Used

v13.0.2

🩺 Test Data / Additional context

ddaecTest.zip


🦄 Related requirements

🦄 #368

⚙️ Engineering Details

@jordanpadams jordanpadams added this to the 11.Jesse.Owens milestone Jul 26, 2021
jshughes added a commit that referenced this issue Aug 5, 2021
Issue with DD_Associate_External_Class when trying to reference pds:Internal_Reference and pds:Local_Internal_Reference

The issue reported seems to be associated with an earlier release of LDDTool. The reported problem could not be duplicated. However on inspection it was discovered that the Assert message was formatted wrong. The message formatting was corrected.

Resolves #391
Refs CCB-256
jshughes added a commit that referenced this issue Aug 5, 2021
Issue with DD_Associate_External_Class when trying to reference pds:Internal_Reference and pds:Local_Internal_Reference

The issue reported seems to be associated with an earlier release of LDDTool. The reported problem could not be duplicated. However on inspection it was discovered that the Assert message was formatted wrong. The message formatting was corrected.

Resolves #391
Refs CCB-256
@jordanpadams jordanpadams reopened this Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants