Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDDTool: XMLSchema Fix Null In Import Cleanup #81

Closed
jshughes416 opened this issue Oct 3, 2019 · 5 comments
Closed

LDDTool: XMLSchema Fix Null In Import Cleanup #81

jshughes416 opened this issue Oct 3, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@jshughes416
Copy link
Contributor

LDDTool general cleanup
MasterDOMInfoModel - move test on testTrue outside of loop
DOMDataType - setting this.nsTitle is not needed since it is set by this.setIdentifier
DMDocument - added "exit" message
XML4LabelSchemaDOM - get info for XML schema namespace declaration - add pds (common) as default
WriteDOMSchematron - get info for XML schema namespace declaration - add pds (common) as default
LDDDOMParser - added helpful comments.

jshughes416 pushed a commit that referenced this issue Oct 3, 2019
LDDTool general cleanup
	MasterDOMInfoModel - move test on testTrue outside of loop
	DOMDataType - setting this.nsTitle is not needed since it is set by this.setIdentifier
	DMDocument - added "exit" message
	XML4LabelSchemaDOM - get info for XML schema namespace declaration - add pds (common) as default
	WriteDOMSchematron - get info for XML schema namespace declaration - add pds (common) as default
	LDDDOMParser - added helpful comments.
jshughes416 added a commit that referenced this issue Oct 3, 2019
…chema_Fix_Null_In_Import_Cleanup

Issue #81 LDDTool_XMLSchema_Fix_Null_In_Import_Cleanup
@jordanpadams jordanpadams changed the title LDDTool_XMLSchema_Fix_Null_In_Import_Cleanup LDDTool: XMLSchema Fix Null In Import Cleanup Oct 4, 2019
@jordanpadams jordanpadams added bug Something isn't working high labels Oct 4, 2019
@rchenatjpl
Copy link

As with #77, it's hard to know what to test.

@jordanpadams
Copy link
Member

@jshughes416 please help out here?

@rchenatjpl
Copy link

Yes, I'll say this one is fixed as well, though I don't understand the problem or the solution.

@jordanpadams
Copy link
Member

@rchenatjpl I think this is under the hood leading to outputs

@jshughes
Copy link
Collaborator

This is the issue where null was in the output file name PDS4_GEOM_null_1700. Here is the test file.

PDS4_IMG_IngestLDD_190928_changeExtensionToXML.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants