Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #641 update date format to be timezone aware #644

Merged
merged 38 commits into from
Mar 29, 2023

Conversation

jshughes
Copy link
Collaborator

Issue #641 Update date format to be timezone aware

Registry manager fails with updates to LDDTool to support ISO Formatted dates #31

Changed java Class used for dateTimeUTC from Date to Instant
DMDocument - deprecated old dateTimeUTC
WriteDOMDDJSONFile - change in file header
WriteDOMTermEntryJSON - change in file header
WriteDOMRDFTTLFile - change in file comment
WriteDOM11179DDPinsFilePClass - removed useless comment related to dateTimeUTC
WriteCoreXMLSchemaLabel - three changes - <creation_date_time> x 2 and <modification_date>

Resolves #641

⚙️ Test Data and/or Report

For comparison, "before" and after "files" are attached. Only the files generated by WriteDOMDDJSONFile and WriteCoreXMLSchemaLabel are included. The other files are not currently "operational". The "before" files have "_prev" in the file name.

♻️ Related Issues

The three changes to WriteCoreXMLSchemaLabel will still validate since the data type ASCII_Date_Time_YMD allows for the new format.

Issue641.zip

git@github.com:NASA-PDS/pds4-information-model.git into main
git@github.com:NASA-PDS/pds4-information-model.git into main

Changed java type used for dateTimeUTC from Date to Instant
	DMDocument - deprecated old dateTimeUTC
	WriteDOMDDJSONFile - change in file header
	WriteDOMTermEntryJSON - change in file header
	WriteDOMRDFTTLFile	- change in file comment
	WriteDOM11179DDPinsFilePClass - removed useless comment
	WriteCoreXMLSchemaLabel - three changes - <creation_date_time> x 2 and
<modification_date>
@jshughes jshughes merged commit 7058d8d into main Mar 29, 2023
@jshughes jshughes deleted the Issue_#641_Update_date_format_to_be_timezone_aware branch March 29, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update date format to be timezone aware
1 participant