-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #641 update date format to be timezone aware #644
Merged
jshughes
merged 38 commits into
main
from
Issue_#641_Update_date_format_to_be_timezone_aware
Mar 29, 2023
Merged
Issue #641 update date format to be timezone aware #644
jshughes
merged 38 commits into
main
from
Issue_#641_Update_date_format_to_be_timezone_aware
Mar 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git@github.com:NASA-PDS/pds4-information-model.git into main
git@github.com:NASA-PDS/pds4-information-model.git into main Changed java type used for dateTimeUTC from Date to Instant DMDocument - deprecated old dateTimeUTC WriteDOMDDJSONFile - change in file header WriteDOMTermEntryJSON - change in file header WriteDOMRDFTTLFile - change in file comment WriteDOM11179DDPinsFilePClass - removed useless comment WriteCoreXMLSchemaLabel - three changes - <creation_date_time> x 2 and <modification_date>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #641 Update date format to be timezone aware
Registry manager fails with updates to LDDTool to support ISO Formatted dates #31
Changed java Class used for dateTimeUTC from Date to Instant
DMDocument - deprecated old dateTimeUTC
WriteDOMDDJSONFile - change in file header
WriteDOMTermEntryJSON - change in file header
WriteDOMRDFTTLFile - change in file comment
WriteDOM11179DDPinsFilePClass - removed useless comment related to dateTimeUTC
WriteCoreXMLSchemaLabel - three changes - <creation_date_time> x 2 and <modification_date>
Resolves #641
⚙️ Test Data and/or Report
For comparison, "before" and after "files" are attached. Only the files generated by WriteDOMDDJSONFile and WriteCoreXMLSchemaLabel are included. The other files are not currently "operational". The "before" files have "_prev" in the file name.
♻️ Related Issues
The three changes to WriteCoreXMLSchemaLabel will still validate since the data type ASCII_Date_Time_YMD allows for the new format.
Issue641.zip