Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #670 Adds to default output JSON TermMap #671

Merged
merged 1 commit into from Aug 10, 2023

Conversation

jshughes
Copy link
Collaborator

The JSON Termmap writer has been added to WriteDOMDDJSONFileLib. The original WriteDOMDDJSONFile will be deprecated after successful testing during I&T. WriteDOMDDJSONFileLib is a refactor of WriteDOMDDJSONFile to use the org.json.simple JSON library.

The output from the refactored WriteDOMDDJSONFileLib seems to produce, in general, the same output as the original WriteDOMDDJSONFile. Cosmetic differences are that the JSON output file needs to be “pretty printed” and the “order” of the "names" was not maintained.

There were a few cases found where a "name" did not exist for a "value". In such cases a "blank node name" was created. The format of the blank node name is "bn#" where # is a sequence number.

Resolves #670
Refs CCB-351

@jshughes jshughes merged commit e856114 into main Aug 10, 2023
2 checks passed
@jshughes jshughes deleted the Issue_#651_AddTermMapToJSONFileFinal branch August 10, 2023 20:32
@sonatype-lift
Copy link

sonatype-lift bot commented Aug 10, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

}

// structure for sorting termEntryDefns
class TermEntryDefnGroup {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

45% of developers fix this issue

ClassCanBeStatic: Inner class is non-static but does not reference enclosing class


Suggested change
class TermEntryDefnGroup {
static class TermEntryDefnGroup {

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

}

// TermEntryDefn Group Map - structure for sorting termEntryDefns
class TermEntryDefnGroupMapStruct {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

45% of developers fix this issue

ClassCanBeStatic: Inner class is non-static but does not reference enclosing class


Suggested change
class TermEntryDefnGroupMapStruct {
static class TermEntryDefnGroupMapStruct {

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@sonatype-lift
Copy link

sonatype-lift bot commented Aug 10, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/NASA-PDS/pds4-information-model/671.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/NASA-PDS/pds4-information-model/671.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adds to default output JSON TermMap
1 participant