Added a warning msg when the lenghts of Table_Character gro… #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ups and the specified group_length mismatch.
jordanpadams
requested changes
Dec 19, 2019
| @@ -141,12 +141,19 @@ private void expandGroupField(GroupFieldBinary group, int outerOffset) { | |||
| int actualGroupLength = getGroupExtent(group); | |||
|
|
|||
| if (groupLength < actualGroupLength) { | |||
| System.err.println("WARNING: GroupFieldBinary attribute group_length is smaller than size of contained fields: " | |||
| System.err.println("\nWARNING: GroupFieldBinary attribute group_length is smaller than size of contained fields: " | |||
There was a problem hiding this comment.
@hhlee445 it actually looks like PDS4 JParser was handling this incorrectly before. the group length from the label and the group length from the product itself must always be ==:
if (groupLength < actualGroupLength) {
throw ParseException("Group Length mismatch:
+ (groupLength * group.getRepetitions().intValueExact())
+ "!="
+ (actualGroupLength * group.getRepetitions().intValueExact()));
}
This will then need to be caught somewhere in validate.
There was a problem hiding this comment.
Additionally, in the PR, since it is in a separate repo, can we be sure to cross-ref to the other repo so we know how it is being closed out?
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a warning msg when the lenghts of Table_Character groups and the specified group_length mismatch.
Resolves NASA-PDS/validate#63