Merge pull request #417 from NASA-PDS/387-log-cleanup-keys

387 log security cleanup
NASA-PDS · Mar 6, 2024 · 07dadb2 · 07dadb2
2 parents 6c13793 + 8a6b344
commit 07dadb2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/service/src/main/java/gov/nasa/pds/api/registry/configuration/AWSSecretsAccess.java b/service/src/main/java/gov/nasa/pds/api/registry/configuration/AWSSecretsAccess.java
@@ -43,7 +43,7 @@ public DefaultKeyValue<String, String> getSecret(String secretName, String regio
       region = REGISTRY_DEFAULT_AWS_REGION;
     }
 
-    log.debug(String.format("Looking up secret %s in region %s", secretName, region));
+    log.debug(String.format("Looking up secret in non-default region %s", region));
 
     // Create a Secrets Manager client
     AWSSecretsManager client = AWSSecretsManagerClientBuilder.standard().withRegion(region).build();

diff --git a/...c/main/java/gov/nasa/pds/api/registry/search/OpenSearchRegistryConnectionImplBuilder.java b/...c/main/java/gov/nasa/pds/api/registry/search/OpenSearchRegistryConnectionImplBuilder.java
@@ -55,11 +55,11 @@ public int getTimeOutSeconds() {
     return timeOutSeconds;
   }
 
-  
+
   public boolean getCCSEnabled() {
     return CCSEnabled;
   }
-  
+
   public boolean isSsl() {
     return ssl;
   }
@@ -123,7 +123,6 @@ public void trySetESCredsFromEnv() {
 
       this.username = esCreds.getKey();
       this.password = esCreds.getValue();
-      log.debug(String.format("ES Username from environment : [%s]", this.username));
     }
   }
 

diff --git a/service/src/test/java/gov/nasa/pds/api/registry/configuration/AWSSecretsAccessTest.java b/service/src/test/java/gov/nasa/pds/api/registry/configuration/AWSSecretsAccessTest.java
@@ -24,14 +24,13 @@ static DefaultKeyValue<String, String> testGetSecret(String secretName) {
     return result;
   }
 
-  public static final void main(String args[]) {
+  public static void main(String[] args) {
     for (String secretName : args) {
       DefaultKeyValue<String, String> secret = testGetSecret(secretName);
       if (secret != null) {
-        log.info(String.format("Secret name : %s, Secret Id : %s / Secret Value : %s", secretName,
-            secret.getKey(), secret.getValue()));
+        log.info("Successfully retrieved secret.");
       } else {
-        log.error(String.format("Lookup for secrete %s returned null.", secretName));
+        log.error("Lookup for secret returned null.");
       }
     }
   }