Swagger UI for prod #254
Merged
Swagger UI for prod #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tloubrieu-jpl
force-pushed
the
swagger-ui-for-prod
branch
2 times, most recently
from
d8ebe18
to
5df0b6c
Compare
Closed
|
Conflicts have been removed but integration tests (postman) do not work on it. It sounds like they do not work on the main branch either but they used to work on this branch (before it was rebase on main). I will investigate that before we do a review. |
al-niessner
approved these changes
Mar 2, 2023
start to solve compilation issues migrate to spring-doc, tested with reverse proxy, logo reintegrated reintegrate other swagger-ui customization sort end-points in swagger-ui, make * Accept header work, start to fix contextPath for references return application/json for Accept:text/html, have reference url work behind reverse proxy add forgotten files
tloubrieu-jpl
force-pushed
the
swagger-ui-for-prod
branch
from
5df0b6c
to
7d579a4
Compare
tloubrieu-jpl
added a commit
to NASA-PDS/registry
that referenced
this pull request
Mar 9, 2023
* set the port of the reverse proxy properly * update tests, order swagger-ui tags alphabetically --------- Co-authored-by: thomas loubrieu <thomas.loubrieu@jpl.nasa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Make swagger-ui work with:
⚙️ Test Data and/or Report
Use PR NASA-PDS/registry#166
♻️ Related Issues
Fixes #245
Fixes #211
Fixes https://github.com/nasa-pds/pds-api/issues/239
Fixes https://github.com/nasa-pds/pds-api/issues/193
NASA-PDS/pds-api#253