-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Registry Manager to support multi-tenancy and OpenSearch Serverless #73
Conversation
The only think to note here, is that arg value changes but everything else remains the same. Instead of https://localhost:9200 will be app://localhost.xml.
Should have separated all of the get/search parts and everything that is es or os is now in registry-common.
Hi @al-niessner , the branch If yes, the pom.xml in this repository should reference dependency on registry-common 1.6.0-SNAPSHOT, but it does not. Can you help me with that ? Thanks |
Yes these 3 PRs work together:
POM updated. When you have this new snapshot let me know and I will update the harvest POM for both common and mgr. |
Hi @al-niessner , I build registry-common from branch
I am not finding the classes missing in the branch issue_36 of registry-common. Thanks |
@tloubrieu-jpl
Is 1.6.0-SNAPSHOT deployed?
common.es.client does not exist anymore. Oh, I guess that means not on the branch in registry-mgr or something.
|
Hi @al-niessner , I am building the registry-common locally and it is deployed locally in my .m2 repository. |
Hi @al-niessner , I tried the set-archive-status subcommand but that did not work, see my terminal here with 2 attempts:
Before I merge the PR, can you also resolve the current conflict with the main branch ? Thanks, Thomas |
How did you resolve conflict from main branch for the status subject? |
Hi @al-niessner , I don't understand your question. I did not resolve the conflict but I was asking if you could do it, by rebasing your development branch on main. And as an independent request from me, I was also asking if you could fix the error when using the set-archive-status subcommand. Let me know what I missed. Thanks |
Fix for status is waiting for you in PR NASA-PDS/registry-common#49. Merge is complete. |
src/main/java/gov/nasa/pds/registry/mgr/cmd/reg/KnownRegistryCmd.java
Fixed
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving although there are remaining know bugs.
🗒️ Summary
Adapt to new registry-common
⚙️ Test Data and/or Report
TBD
♻️ Related Issues
Closes #66