Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaled value min/max error does not display scaled value #434

Closed
jstone-psi opened this issue Oct 28, 2021 · 2 comments
Closed

Scaled value min/max error does not display scaled value #434

jstone-psi opened this issue Oct 28, 2021 · 2 comments

Comments

@jstone-psi
Copy link

🐛 Describe the bug

When validating an image that has a scaled value that is out of range, the error message displays the unscaled value, instead of the scaled value, which is confusing and misleading.

📜 To Reproduce

Steps to reproduce the behavior:
Run the validator on the included label:

validate st_2480739249_v.xml

🕵️ Expected behavior

The error message should display the scaled value (-128.0) instead of the unscaled value (0) in the error message. So the correct error message would be

ERROR [error.array.value_out_of_scaled_min_max_range] array 1, location (1, 1): Scaled value is less than the scaled minimum value in the label (min=-126.0, got=-128.0).

instead of

ERROR [error.array.value_out_of_scaled_min_max_range] array 1, location (1, 1): Scaled value is less than the scaled minimum value in the label (min=-126.0, got=0).

📚 Version of Software Used

validate 2.1.0

🩺 Test Data / Additional context

st_2480739249_v.zip

🏞Screenshots

🖥 System Info

  • OS: MacOS Big Sur
  • Java: openjdk 17

🦄 Related requirements

⚙️ Engineering Details

@jstone-psi jstone-psi added bug Something isn't working needs:triage labels Oct 28, 2021
@jstone-psi
Copy link
Author

I accidentally ran this on 2.0.7 in the attached report. Here's another error log that shows it running on 2.1.0.

st_2480739249_v.txt

@jordanpadams
Copy link
Member

closed per #514 and #529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants