Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitignore rules are overreaching #217

Closed
ivanperez-keera opened this issue Jul 24, 2023 · 0 comments
Closed

gitignore rules are overreaching #217

ivanperez-keera opened this issue Jul 24, 2023 · 0 comments
Assignees
@ivanperez-keera
Labels
P-low Priority: Low
Milestone
ikos 3.2

Comments

@ivanperez-keera
Copy link
Collaborator

ivanperez-keera commented Jul 24, 2023 •
edited
Loading

The .gitignore rules are matching build and install filenames and directories outside of the root of the tree.

This causes, for example, files under doc/install to be ignored, which is not intended.

It'd be better to match only directories and to whitelist that particular directory.

This issue was originally reported by @nuclearsandwich.
ivanperez-keera added a commit to ivanperez-keera/ikos that referenced this issue Jul 24, 2023
@ivanperez-keera
Make git ignore build and install as directories, but not as files (N…
bdc319e 
…ASA-SW-VnV#217).

The .gitignore rules are matching build and install filenames and directories
outside of the root of the tree, which causes any file in the project with
those names to be ignored.

This commit modifies the .gitignore to match only directories with the names
build and install, not files. This is standard in projects that use cmake.
ivanperez-keera added a commit to ivanperez-keera/ikos that referenced this issue Jul 24, 2023
@ivanperez-keera
Make git not ignore doc/install (NASA-SW-VnV#217).
81e896b 
The .gitignore rules are causing the directory doc/install to be ignored, which
is not desirable.

This commit specifically whitelists doc/install/.
@ivanperez-keera ivanperez-keera added this to the ikos 3.2 milestone Jul 25, 2023
@ivanperez-keera ivanperez-keera self-assigned this Jul 25, 2023
@ivanperez-keera ivanperez-keera added the P-low Priority: Low label Jul 25, 2023
arthaud pushed a commit that referenced this issue Jul 25, 2023
@ivanperez-keera @arthaud
Make git ignore build and install as directories, but not as files (#217
1895b11 
).

The .gitignore rules are matching build and install filenames and directories
outside of the root of the tree, which causes any file in the project with
those names to be ignored.

This commit modifies the .gitignore to match only directories with the names
build and install, not files. This is standard in projects that use cmake.
arthaud pushed a commit that referenced this issue Jul 25, 2023
@ivanperez-keera @arthaud
Make git not ignore doc/install (#217).
18a5d0b 
The .gitignore rules are causing the directory doc/install to be ignored, which
is not desirable.

This commit specifically whitelists doc/install/.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanperez-keera ivanperez-keera

Labels
P-low Priority: Low
Projects
None yet
Milestone
ikos 3.2
Development

No branches or pull requests
1 participant
@ivanperez-keera