Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugo site link adjustments #77

Merged
merged 4 commits into from
Aug 7, 2017
Merged

Conversation

eirizarry
Copy link

This pull request closes #76

  • Link to NASA Ames site was added to the "Contact" page
  • Links to Web WorldWind examples now launch the examples themselves, rather than taking user to code view
  • Web WorldWind examples' links open in new tab
  • Made one final grammar check

The links to the Web WorldWind examples led to the GitHub code review rather than launching the example itself.

- Links now launch the examples on worldwindserver.net.
- Clicking on links opens a new tab.
@eirizarry eirizarry requested a review from pdavidc August 7, 2017 18:25
@ghost ghost assigned eirizarry Aug 7, 2017
@ghost ghost added the needs review label Aug 7, 2017
Copy link
Contributor

@pdavidc pdavidc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I found two typos in old code unrelated to this change, but that we ought to fix now.

@@ -12,7 +12,7 @@ draft: false

Patrick Hogan - [patrick.hogan@nasa.gov](mailto://patrick.hogan@nasa.gov)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link should be "mailto:patrick.hogan@nasa.gov". The forward slashes are erroneous.

@@ -12,7 +12,7 @@ draft: false

Patrick Hogan - [patrick.hogan@nasa.gov](mailto://patrick.hogan@nasa.gov)

The WorldWind project is managed from the NASA Ames Research Center at Moffett Field, CA.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the NASA Ames Research Center" ought to be "NASA Ames Research Center"

@pdavidc pdavidc mentioned this pull request Aug 7, 2017
9 tasks
@pdavidc pdavidc merged commit 6ae0da2 into develop Aug 7, 2017
@pdavidc pdavidc deleted the feature/#76-link-adjustments branch August 7, 2017 19:24
@ghost ghost removed the needs review label Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants