Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix horizon clipping of atmosphere #102

Closed

Conversation

strangerintheq
Copy link

bug: using AtmosphereLayer with zoom and tilt will cause unnecessary clipping of image generated by SkyProgram

here is a bugfix

@AkeluX
Copy link
Contributor

AkeluX commented Apr 3, 2017

Thank you. We'll look into this issue and your fix.

@strikerM any thoughts on this?

@strikerM
Copy link
Contributor

strikerM commented Apr 3, 2017

In my opinion, we should use the same method as WorldWindAndroid for handling the clipping of the sky atmosphere.
https://github.com/NASAWorldWind/WorldWindAndroid/blob/master/worldwind/src/main/java/gov/nasa/worldwind/WorldWindow.java#L1023

I think the new Camera implementation should fix this issue.

@pdavidc @balhar-jakub

@strangerintheq
Copy link
Author

does this method can handle elevations?

@strikerM
Copy link
Contributor

strikerM commented Apr 4, 2017

I'm not sure I understand the question.
The Sky Atmosphere doesn't "follow" the terrain.

@pdavidc
Copy link
Contributor

pdavidc commented Apr 4, 2017

@strikerM is right, the WorldWindAndroid method resolves this issue.

@pdavidc pdavidc added the request label Apr 4, 2017
@strangerintheq
Copy link
Author

Clipping is cool, but what about negative elevations? Is method handle situation With max tilt and zoom in area in pacific ocean?

@AkeluX
Copy link
Contributor

AkeluX commented Apr 7, 2017

Thank you for your inputs. We propose to continue the discussion in #105 as we won't take this pull request as is.

@AkeluX AkeluX closed this Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants