Fixed clipping of Atmosphere #118
Conversation
…here and above-ground placemarks beyond horizon. - The constant (1.5e6 meters) is based on the distance to the horizon from the upper region of the atmosphere.
| this.farDistance = WWMath.horizonDistanceForGlobeRadius(globeRadius, eyePos.altitude); | ||
| if (this.farDistance < 1e3) | ||
| this.farDistance = 1e3; | ||
| this.farDistance = WWMath.horizonDistanceForGlobeRadius(globeRadius, eyePos.altitude) + 1.5e6; |
There was a problem hiding this comment.
@emxsys Instead of the fixed 1.5e6, WWA asks for the horizon distance of the atmosphere height. Would this be better here? See https://github.com/NASAWorldWind/WorldWindAndroid/blob/develop/worldwind/src/main/java/gov/nasa/worldwind/WorldWindow.java#L1041
There was a problem hiding this comment.
The precomputed horizon distance in the original pull request is correct, but it has two issues: it's specific to Earth, and it's inconsistent with the pattern in Android. It seems to me that we could take this change if it were in line with what's done in Android. I suspect that @emxsys will agree that it'll be easier to keep the two SDKs synchronized if we avoid arbitrary differences.
There was a problem hiding this comment.
If you have time to make the necessary changes, we can approve this PR. Otherwise, I'd be happy to open a new PR from an in-repository branch.
|
Closed in favor of #172, which bring's Web WorldWind's far clip distance into parity with WorldWind Android. |
ghost
removed
the
Adjusted the far clip plane to account for the atmosphere and above-ground placemarks beyond horizon.
Before the fix, notice black line on the horizon:
After the fix, atmosphere appears correct:
Sunrise/sunset effect works now:
Placemarks now visible beyond the horizon:
