Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for retrieving imagery from sources requiring credentials #268

Merged
merged 4 commits into from
Nov 8, 2017

Conversation

AkeluX
Copy link
Contributor

@AkeluX AkeluX commented Nov 1, 2017

Description of the Change

Add a crossOrigin property to TiledImageLayer in order to allow application developers to configure the corresponding property of the image requests for a particular image layer.

Why Should This Be In Core?

This is a change to a core class.

Benefits

Enable using WebWorldWind with data sources requiring credentials to be sent.

Potential Drawbacks

We discussed a larger refactoring to address in a common way all requests for external resources including additional options, but I would like to get this in as a first step.

Applicable Issues

Closes #76

@AkeluX AkeluX self-assigned this Nov 1, 2017
@AkeluX AkeluX requested a review from pdavidc November 1, 2017 09:00
@ghost ghost added the needs review label Nov 1, 2017
@pdavidc pdavidc added this to the WebWW v0.9.0 milestone Nov 8, 2017
@pdavidc pdavidc requested a review from Beak-man November 8, 2017 19:06
@ghost ghost assigned Beak-man Nov 8, 2017
Copy link
Member

@Beak-man Beak-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A refactoring with a broader scope will be considered later, as mentioned in #76.

@Beak-man Beak-man merged commit e5660f2 into develop Nov 8, 2017
@ghost ghost removed the needs review label Nov 8, 2017
@pdavidc pdavidc deleted the fix/tiled-image-layer-use-credentials branch November 8, 2017 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants