Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--translate option does not work anymore #53

Closed
Juke34 opened this issue Jun 10, 2020 · 11 comments · Fixed by #61
Closed

--translate option does not work anymore #53

Juke34 opened this issue Jun 10, 2020 · 11 comments · Fixed by #61

Comments

@Juke34
Copy link
Collaborator

Juke34 commented Jun 10, 2020

line 607 of feature.py has to be replaced by
translated_seq = str(seq.translate(codon_table)).replace('B','X').replace('Z','X').replace('J','X')

@Jeepee8820
Copy link

Hi Jacques,

Sorry to bother you again but it seems to me that the translate option does not take into consideration the change to Met when at start. I used the parameters --transl_table 11 and --translate and Webin CLI complains about ERROR: Expected and conceptual translations are different. The translations at these positions do indeed start with L, I or V instead of M.
Any fix possible? Thanks in advance

@Juke34
Copy link
Collaborator Author

Juke34 commented Jun 25, 2020

Right good catch! If biopython deals with that it should be fixable easily otherwise I would need to implement something. Anyway, You do not need to include the translation when submitting to ENA. They will do it for you. This option is actually not really useful for submission purpose.

@Jeepee8820
Copy link

Thanks Jacques. Great to read that it's not needed to include translation when submitting to ENA.

@sanyalab
Copy link

Hi Jacques,

Will you still be including this fix for the tool? even if it is not required by ENA?

Thanks
Abhijit

@Juke34
Copy link
Collaborator Author

Juke34 commented Jul 14, 2020

It is planned, but I cannot tell you when. At the latest when I will be back from parental leave in November 😁. Otherwise everyone is welcome to PR the required changes.

@sanyalab
Copy link

sanyalab commented Jul 15, 2020 via email

@Juke34
Copy link
Collaborator Author

Juke34 commented Oct 21, 2020

Should be fixed by now. You can try it by installing the version in the speed branch.
I will soon merge it to the master branch and then release an official new version

@sanyalab
Copy link

sanyalab commented Oct 21, 2020 via email

@Juke34
Copy link
Collaborator Author

Juke34 commented Oct 21, 2020

Better to ask that kind of thing on the related Repo to keep the thread clear. The script is definitely in AGAT: https://github.com/NBISweden/AGAT/tree/master/bin
But the name is slightly different now agat_sq_manage_IDs.pl. The wiki is from an older version

@sanyalab
Copy link

Should be fixed by now. You can try it by installing the version in the speed branch.
I will soon merge it to the master branch and then release an official new version

Hi Jacques,

Is the above fix in Conda? I have the tool installed via anaconda.

Thanks
Abhijit

@Juke34
Copy link
Collaborator Author

Juke34 commented Feb 18, 2021

Hi @sanyalab, I didn't merge the branch waiting for feeback from users.
If you want to use this branch just install over the emblymygff3 conda env you already have or create a new env follwing theses steps:

conda create -n emblmygff3_speed
conda activate emblmygff3_speed
conda --install -c bioconda emblmygff3
git clone https://github.com/NBISweden/EMBLmyGFF3.git
cd EMBLmyGFF3
git checkout speed
python setup.py install

Then you can use EMBLmyGFF3 normally

@Juke34 Juke34 mentioned this issue Feb 24, 2021
@Juke34 Juke34 closed this as completed in #61 Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants