This repository has been archived by the owner on Dec 16, 2019. It is now read-only.
Improve image base and CI build #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankdots
force-pushed
the
feature/image-re-base
branch
from
427f5d5
to
384336e
Compare
blankdots
changed the title
dtitov
approved these changes
Sep 20, 2018
viklund
approved these changes
Sep 20, 2018
viklund
pushed a commit
that referenced
this pull request
Nov 22, 2018
Improve image base and CI build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the OS (packages + python install) from actual source code in order to streamline build based on an idea by @silverdaz, an effort to improve: #348
Part of this PR:
7.5.1804ega-os,ega-base,ega-opensshandega-inboxega-osandega-opensshshould be built only if theDockerfilehas changed, we useextras/travis.shfor this.ega-basethe LocalEGA app, probably the most frequently changed.ega-inboxmakes use of of multi stage builds and usesega-baseandega-opensshimages. Should be built as theega-basechanges.No. Image names and configuration stayed the same.
As it stands check the
extras/travis.shand after merge we should do two additional PRs one with aimages/os/Dockerfilechange and one without.Yes indeed, but there was a bug #225 and we fixed the version. In the meantime rabbitmq 3.7 changed their configuration formatting: http://www.rabbitmq.com/blog/2018/02/22/new-configuration-format-in-rabbitmq-3-7/ . If enough interest and depending on CEGA version we might change it. Mostly because of security updates.
We should increase travis
sleep, run again that job or be smart about it and modify the integration tests and make it wait for services to be up.