This repository has been archived by the owner on Dec 16, 2019. It is now read-only.
filepath, filename gets correctly set in send_message #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated the names of the parameters so that they don't get overwritten by the function body - this reduces the amount of state one has to keep track of when reading the function.
blankdots
approved these changes
Sep 28, 2018
silverdaz
reviewed
Sep 28, 2018
viklund
pushed a commit
that referenced
this pull request
Nov 22, 2018
filepath, filename gets correctly set in send_message
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filepath, filename gets correctly set in send_message
Also updated the names of the parameters so that they don't get
overwritten by the function body - this reduces the amount of state one
has to keep track of when reading and/or updating the function.
Describe the pull request:
Changes made:
notifications.py- fixed bug according to aboveSteps to reproduce the original issue
1f9d197and make sure that all docker images are built against that revisionlog = consoleinprivate/lega/conf.inidocker-compose upmake uploadin a different terminal inside thedocker/testdirectoryThe (relevant) log output from docker-compose will be: