-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ANI filter, vignettes, pathogens to list, fixed a few bugs, tuned fontsize for heatmaps #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
percyfal
reviewed
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LeandroRitter only minor comments, LGTM.
There is a small typo that comes up twice in the readme as well :
KarkenUniq abundance matrix
Instead of KrakenUniq
Le mer. 9 août 2023, 16:58, Nikolay Oskolkov ***@***.***> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In workflow/rules/authentic.smk
<#134 (comment)>:
> @@ -89,7 +92,7 @@ checkpoint Malt_Extract:
message:
"Malt_Extract: RUNNING MALT EXTRACT FOR SAMPLE {input.rma6}"
shell:
- "time MaltExtract -i {input.rma6} -f def_anc -o {params.extract} --reads --threads {threads} --matches --minPI 85.0 --maxReadLength 0 --minComp 0.0 --meganSummary -t {input.node_list} -v 2> {log}"
+ "time MaltExtract -Xmx32G -i {input.rma6} -f def_anc -o {params.extract} -r {params.ncbi_db} --reads --threads {threads} --matches --minPI 85.0 --maxReadLength 0 --minComp 0.0 --meganSummary -t {input.node_list} -v 2> {log}"
I believe, the -r flag should be there by default because we have a rule
NCBIMapTre that downloads ncbi.map and ncbi.tre and places them to ncbi_db.
In case, the downloading fails, when there is not internet connection as TJ
noticed, there should be at least a chance to point MaltExtract to ncbi_db
where one could manually upload the ncbi.map and ncbi.tre files. I ran
aMeta with the -r flag a few times on my laptop and Uppmax, i.e. with
internet connection, and it always worked
—
Reply to this email directly, view it on GitHub
<#134 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASTPL5FRDYBT43EIESXW3ITXUOQPVANCNFSM6AAAAAA234DLI4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
percyfal
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.