Skip to content

Commit

Permalink
Merge pull request #609 from NBISweden/bugfix/fix-rsid-errormsg
Browse files Browse the repository at this point in the history
Fix useless error message for rsids
  • Loading branch information
talavis committed Apr 6, 2020
2 parents eb4ed74 + fa6ceb6 commit e16ad75
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions backend/modules/browser/lookups.py
Original file line number Diff line number Diff line change
Expand Up @@ -520,13 +520,13 @@ def get_variants_by_rsid(dataset: str, rsid: str, ds_version: str = None) -> lis
raise error.NotFoundError(f'Unable to find the dataset version in the database')

if not rsid.startswith('rs'):
logging.error('get_variants_by_rsid({dataset}, {rsid}): rsid not starting with rs')
logging.warning(f'get_variants_by_rsid({dataset}, {rsid}): rsid not starting with rs')
raise error.ParsingError('rsid not starting with rs')

try:
int_rsid = int(rsid.lstrip('rs'))
except ValueError as err:
logging.error('get_variants_by_rsid({}, {}): not an integer after rs'.format(dataset, rsid))
logging.warning(f'get_variants_by_rsid({dataset}, {rsid}): not an integer after rs')
raise error.ParsingError('Not an integer after rs') from err

variants = (db.Variant
Expand Down

0 comments on commit e16ad75

Please sign in to comment.