Fix error when checking is_admin #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same problem as with send_error(): the function keeps on running unless explicitly told not to.
talavis
force-pushed
the
bugfix/linus-isadmin
branch
from
4a9d543
to
35d4b5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
is_admin was raising an AttributeError as version was a string, and did thus not have the member dataset. It will now use the dataset_version object instead.
Fixing the problem also identified the problem that the function continued after send_error(), causing finish() to be called twice.
The same problem also occurs with calling finish inside (not at the end of) a function.
Changes made: