Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes exceptions due to DoesNotExist when looking up dataset versions #502

Merged
merged 2 commits into from
Jan 10, 2019

Conversation

talavis
Copy link
Contributor

@talavis talavis commented Jan 9, 2019

Describe the pull request:

  • Bug fix
  • Functional change
  • New feature
  • Code cleanup
  • Build system change
  • Documentation change
  • Language translation

Pull request long description:

Whenever a non-existing dataset was requested, an exception was raised. With these changes, the failed request will be logged and None will be returned from the function. Also added handling for this.

Changes made:

Exception handling for the requests in db.py, management of the returned None.

Copy link
Member

@viklund viklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@viklund viklund merged commit 66e4c32 into develop Jan 10, 2019
@viklund viklund deleted the bugfix/fix-doesnotexist-exceptions branch January 10, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants