Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse multiple rsids #511

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Conversation

MalinAhlberg
Copy link
Member

Describe the pull request:

  • Bug fix
  • Functional change
  • New feature
  • Code cleanup
  • Build system change
  • Documentation change
  • Language translation

Pull request long description:

For lines with more than one variant, eg:

22 16577044 rs374006257;rs200929253 TG AG,T

use the first rsid for the first variation, the second rsid for the second variation, and so on:

rs374006257: TG->AG
rs200929253: AG->T

For

2 16879601 rs371560503 T TA,TAA

we get

rs371560503: T->TA
rs371560503: T->TAA

Copy link
Contributor

@talavis talavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me like it should keep the same result for the "real" datasets, so should be fine. Not tested.

@talavis talavis merged commit c9e5af5 into feature/postgres-database Feb 21, 2019
@MalinAhlberg MalinAhlberg deleted the feature/multiple_rsids branch February 21, 2019 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants